aboutsummaryrefslogtreecommitdiffstats
path: root/src/crypto
diff options
context:
space:
mode:
authorJouni Malinen <jouni@qca.qualcomm.com>2015-12-28 16:12:03 (GMT)
committerJouni Malinen <j@w1.fi>2015-12-28 16:12:03 (GMT)
commit15a68138c1da0ec509d09bbd143c17abc720b29a (patch)
tree64fd93cf8fb8552fd79421f7d3e6864434d02945 /src/crypto
parentb90b3eab1f5af41de86e110b35b949261e7933ea (diff)
downloadhostap-15a68138c1da0ec509d09bbd143c17abc720b29a.zip
hostap-15a68138c1da0ec509d09bbd143c17abc720b29a.tar.gz
hostap-15a68138c1da0ec509d09bbd143c17abc720b29a.tar.bz2
Remove unnecessary cleanup assignment in SHA1Final()
This makes some static analyzers complain about stored value never being read. While it is good to clear some other temporary variables, this local variable i has no security private information (it has a fixed value of 20 here) and trying to clear it to 0 does not add any value. Remove that part of the "wipe variables" to avoid one useless static analyzer complaint. Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
Diffstat (limited to 'src/crypto')
-rw-r--r--src/crypto/sha1-internal.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/crypto/sha1-internal.c b/src/crypto/sha1-internal.c
index f6658e6..ffcba66 100644
--- a/src/crypto/sha1-internal.c
+++ b/src/crypto/sha1-internal.c
@@ -297,7 +297,6 @@ void SHA1Final(unsigned char digest[20], SHA1_CTX* context)
255);
}
/* Wipe variables */
- i = 0;
os_memset(context->buffer, 0, 64);
os_memset(context->state, 0, 20);
os_memset(context->count, 0, 8);