aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJouni Malinen <jouni@qca.qualcomm.com>2015-07-30 19:10:46 (GMT)
committerJouni Malinen <j@w1.fi>2015-07-30 19:13:47 (GMT)
commit34c5267bbc3093fab170e4c843a10c2c70ed27c2 (patch)
tree1b9402093888fab6b9997d679eeaed96a10188cc
parent983422088f0066068fd364013623d1e475031e6b (diff)
downloadhostap-34c5267bbc3093fab170e4c843a10c2c70ed27c2.zip
hostap-34c5267bbc3093fab170e4c843a10c2c70ed27c2.tar.gz
hostap-34c5267bbc3093fab170e4c843a10c2c70ed27c2.tar.bz2
Return error from wpa_drv_get_pref_freq_list() if no driver support
Commit 983422088f0066068fd364013623d1e475031e6b ('nl80211: Add means to query preferred channels') return success if no driver wrapper callback was provided for fetching the preferred channel list. That is problematic since the *num argument is not updated and uninitialized freq_list could end up getting used with arbitrary frequency values. Fix this by returning error in case the values were not available due to driver wrapper not implementing the function. This matches the style used in the driver_nl80211.c implementation for the case where the driver does not support such fetch operation. Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
-rw-r--r--wpa_supplicant/driver_i.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/wpa_supplicant/driver_i.h b/wpa_supplicant/driver_i.h
index 909515b..73768c7 100644
--- a/wpa_supplicant/driver_i.h
+++ b/wpa_supplicant/driver_i.h
@@ -899,7 +899,7 @@ static inline int wpa_drv_get_pref_freq_list(struct wpa_supplicant *wpa_s,
unsigned int *freq_list)
{
if (!wpa_s->driver->get_pref_freq_list)
- return 0;
+ return -1;
return wpa_s->driver->get_pref_freq_list(wpa_s->drv_priv, if_type,
num, freq_list);
}