aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJouni Malinen <j@w1.fi>2003-07-11 14:22:20 (GMT)
committerJouni Malinen <j@w1.fi>2003-07-11 14:22:20 (GMT)
commita8a165d8bbffa2028a58cce1a9b45501be986331 (patch)
tree43c6d369a135e39509f220fcc6ad10caf211628b
parent609cea90383f63bc3aa64a864a24c20078d5fd70 (diff)
downloadhostap-history-a8a165d8bbffa2028a58cce1a9b45501be986331.zip
hostap-history-a8a165d8bbffa2028a58cce1a9b45501be986331.tar.gz
hostap-history-a8a165d8bbffa2028a58cce1a9b45501be986331.tar.bz2
Do not report dropping of frames without ToDS or FromDS flags if they are
directed to foreign BSSID. This kind of frames are normal broadcast frames from IBSS networks and should be dropped silently.
-rw-r--r--driver/modules/hostap_ap.c15
-rw-r--r--todo.lst2
2 files changed, 10 insertions, 7 deletions
diff --git a/driver/modules/hostap_ap.c b/driver/modules/hostap_ap.c
index 44054d6..ac3f9f0 100644
--- a/driver/modules/hostap_ap.c
+++ b/driver/modules/hostap_ap.c
@@ -3082,11 +3082,16 @@ ap_rx_ret hostap_handle_sta_rx(local_info_t *local, struct net_device *dev,
* stats and PS state. Nullfunc frames do not contain
* any data and they will be dropped below. */
} else {
- printk(KERN_DEBUG "%s: dropped received packet from "
- MACSTR " with no ToDS flag (type=0x%02x, "
- "subtype=0x%02x)\n", dev->name,
- MAC2STR(hdr->addr2), type, stype);
- hostap_dump_rx_80211(dev->name, skb, rx_stats);
+ /* If BSSID (Addr3) is foreign, this frame is a normal
+ * broadcast frame from an IBSS network. Drop it silently.
+ * If BSSID is own, report the dropping of this frame. */
+ if (memcmp(hdr->addr3, dev->dev_addr, ETH_ALEN) == 0) {
+ printk(KERN_DEBUG "%s: dropped received packet from "
+ MACSTR " with no ToDS flag (type=0x%02x, "
+ "subtype=0x%02x)\n", dev->name,
+ MAC2STR(hdr->addr2), type, stype);
+ hostap_dump_rx_80211(dev->name, skb, rx_stats);
+ }
ret = AP_RX_DROP;
goto out;
}
diff --git a/todo.lst b/todo.lst
index e29801e..0aea4ac 100644
--- a/todo.lst
+++ b/todo.lst
@@ -80,8 +80,6 @@
2: eth0: <BROADCAST,MULTICAST,UP> mtu 1500 qdisc pfifo_fast qlen 100
link/ether 00:06:5b:a2:b3:8a brd ff:ff:ff:ff:ff:ff
inet 192.168.1.1 peer 192.168.5.1/32 scope global eth0
-- test IBSS broadcast messages and hostap_handle_sta_rx() message about
- "dropped... with no ToDS flag"; should just silently drop the packet
- deauth if WEP frame received when there is no key for the used keyid
- STA f/w 1.4.9 does not seem to provide beacon frames to the driver in
Host AP mode --> automatic WDS creation does not work