diff options
| author | Jouni Malinen <jouni@qca.qualcomm.com> | 2015-07-17 13:59:09 (GMT) |
|---|---|---|
| committer | Jouni Malinen <j@w1.fi> | 2015-07-17 16:06:48 (GMT) |
| commit | f5f1cc93070bb91b3444191b20e13319135f0a9e (patch) | |
| tree | 3ea8426395e8e9bbc17b08f4cc6d5e95658a8073 /src/fst | |
| parent | 2bb51eddad7d877566e42a17368f2767b3aab0a0 (diff) | |
| download | hostap-f5f1cc93070bb91b3444191b20e13319135f0a9e.zip hostap-f5f1cc93070bb91b3444191b20e13319135f0a9e.tar.gz hostap-f5f1cc93070bb91b3444191b20e13319135f0a9e.tar.bz2 | |
FST: Clean up fst_group_update_ie()
None of the callers passed in cleaning_up == TRUE, so drop that unused
code path.
Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
Diffstat (limited to 'src/fst')
| -rw-r--r-- | src/fst/fst.c | 8 | ||||
| -rw-r--r-- | src/fst/fst_group.c | 25 | ||||
| -rw-r--r-- | src/fst/fst_group.h | 2 |
3 files changed, 14 insertions, 21 deletions
diff --git a/src/fst/fst.c b/src/fst/fst.c index b70ef36..a6d0de9 100644 --- a/src/fst/fst.c +++ b/src/fst/fst.c @@ -95,7 +95,7 @@ struct fst_iface * fst_attach(const char *ifname, const u8 *own_addr, } fst_group_attach_iface(group, iface); - fst_group_update_ie(group, FALSE); + fst_group_update_ie(group); foreach_fst_ctrl_call(on_iface_added, iface); @@ -117,7 +117,7 @@ void fst_detach(struct fst_iface *iface) foreach_fst_ctrl_call(on_iface_removed, iface); fst_group_detach_iface(group, iface); fst_iface_delete(iface); - fst_group_update_ie(group, FALSE); + fst_group_update_ie(group); fst_group_delete_if_empty(group); } @@ -194,7 +194,7 @@ void fst_notify_peer_connected(struct fst_iface *iface, const u8 *addr) return; #ifndef HOSTAPD - fst_group_update_ie(fst_iface_get_group(iface), FALSE); + fst_group_update_ie(fst_iface_get_group(iface)); #endif /* HOSTAPD */ fst_printf_iface(iface, MSG_DEBUG, MACSTR " became connected", @@ -210,7 +210,7 @@ void fst_notify_peer_disconnected(struct fst_iface *iface, const u8 *addr) return; #ifndef HOSTAPD - fst_group_update_ie(fst_iface_get_group(iface), FALSE); + fst_group_update_ie(fst_iface_get_group(iface)); #endif /* HOSTAPD */ fst_printf_iface(iface, MSG_DEBUG, MACSTR " became disconnected", diff --git a/src/fst/fst_group.c b/src/fst/fst_group.c index 3880f5e..e362aa2 100644 --- a/src/fst/fst_group.c +++ b/src/fst/fst_group.c @@ -444,25 +444,18 @@ Boolean fst_group_delete_if_empty(struct fst_group *group) } -void fst_group_update_ie(struct fst_group *g, Boolean cleaning_up) +void fst_group_update_ie(struct fst_group *g) { struct fst_iface *i; foreach_fst_group_iface(g, i) { - if (!cleaning_up) { - struct wpabuf *mbie = fst_group_create_mb_ie(g, i); - - if (!mbie) - fst_printf_iface(i, MSG_WARNING, - "cannot create MB IE"); - - fst_iface_attach_mbie(i, mbie); - fst_iface_set_ies(i, mbie); - fst_printf_iface(i, MSG_DEBUG, - "multi-band IE set to %p", mbie); - } else { - fst_iface_attach_mbie(i, NULL); - fst_iface_set_ies(i, NULL); - } + struct wpabuf *mbie = fst_group_create_mb_ie(g, i); + + if (!mbie) + fst_printf_iface(i, MSG_WARNING, "cannot create MB IE"); + + fst_iface_attach_mbie(i, mbie); + fst_iface_set_ies(i, mbie); + fst_printf_iface(i, MSG_DEBUG, "multi-band IE set to %p", mbie); } } diff --git a/src/fst/fst_group.h b/src/fst/fst_group.h index 4f33599..9dcc666 100644 --- a/src/fst/fst_group.h +++ b/src/fst/fst_group.h @@ -27,7 +27,7 @@ void fst_group_attach_iface(struct fst_group *g, struct fst_iface *i); void fst_group_detach_iface(struct fst_group *g, struct fst_iface *i); void fst_group_delete(struct fst_group *g); -void fst_group_update_ie(struct fst_group *g, Boolean cleaning_up); +void fst_group_update_ie(struct fst_group *g); static inline Boolean fst_group_has_ifaces(struct fst_group *g) { |