path: root/src/eapol_auth
diff options
authorJouni Malinen <jouni@qca.qualcomm.com>2015-10-13 22:12:44 (GMT)
committerJouni Malinen <j@w1.fi>2015-10-14 15:43:26 (GMT)
commitae7d9fbd3d037f7e123f71cbe29f858c901a1532 (patch)
treedc60630758720e341782dfb0035b714fff258a08 /src/eapol_auth
parent1b822f52e6356e78938f285d511d458e202fbc76 (diff)
Remove unreachable PMKSA cache entry addition on Access-Accept
The previous implementation used an obsolete sm->eapol_key_crypt pointer which was not set anywhere (i.e., was always NULL). In addition, the condition of sm->eap_if->eapKeyAvailable was not valid here since this is the case of MSK from an external authentication server and not the internal EAP server. Consequently, the wpa_auth_pmksa_add() call here was never used. The PMKSA cache was still added, but it happened at the completion of the 4-way handshake rather than at the completion of EAP authentication. That later location looks better, so delete the unreachable code in Access-Accept handling. In addition, remove the now complete unused struct eapol_state_machine eapol_key_* variables. Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
Diffstat (limited to 'src/eapol_auth')
1 files changed, 0 insertions, 6 deletions
diff --git a/src/eapol_auth/eapol_auth_sm_i.h b/src/eapol_auth/eapol_auth_sm_i.h
index a29b49c..aa3e117 100644
--- a/src/eapol_auth/eapol_auth_sm_i.h
+++ b/src/eapol_auth/eapol_auth_sm_i.h
@@ -162,12 +162,6 @@ struct eapol_state_machine {
struct radius_class_data radius_class;
struct wpabuf *radius_cui; /* Chargeable-User-Identity */
- /* Keys for encrypting and signing EAPOL-Key frames */
- u8 *eapol_key_sign;
- size_t eapol_key_sign_len;
- u8 *eapol_key_crypt;
- size_t eapol_key_crypt_len;
struct eap_sm *eap;
Boolean initializing; /* in process of initializing state machines */